benwtrent commented on PR #13553: URL: https://github.com/apache/lucene/pull/13553#issuecomment-2215645063
@gautamworah96 @msokolov this might be part of the reason for the OOMs, the estimates were completely ignoring the float[] vector sizes for fieldwriters 🤦 . I plan on iterating on this fix first, then proceed with https://github.com/apache/lucene/pull/13538 The other PR helps reduce heap usage slightly, but not by much. Honestly, the issue is that we just weren't tracking the usage in the estimate correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
