benwtrent commented on code in PR #13553: URL: https://github.com/apache/lucene/pull/13553#discussion_r1669465330
########## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsWriter.java: ########## @@ -299,9 +299,7 @@ public void finish() throws IOException { @Override public long ramBytesUsed() { long total = SHALLOW_RAM_BYTES_USED; - for (FieldWriter field : fields) { - total += field.ramBytesUsed(); - } + total += rawVectorDelegate.ramBytesUsed(); Review Comment: rawVectorDelegate takes into account its field writer estimates which then take the scalar quantized writer estimates into account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org