jpountz commented on PR #13542: URL: https://github.com/apache/lucene/pull/13542#issuecomment-2214643611
> The change in expectation should be reflected in the Collector API semantics though (rather that CollectorManager?), is that what you meant? I was referring to `CollectorManager` because we could have two partitions of the same leaf that are collected by two different `Collector`s of the same `CollectorManager`. So both collectors would see this leaf only once, but we still need to avoid double-counting this leaf. > It would need to be made synchronized and it would need to track which leaves were early terminated? Something like that indeed. And only try to apply the `Weight#count` optimization on the first time that `getLeafCollector` is called on a leaf to avoid hitting the problem you had with `LRUQueryCache`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
