gsmiller commented on PR #13463: URL: https://github.com/apache/lucene/pull/13463#issuecomment-2155669750
Ah @benwtrent good catch. Semi-sneaky that `updatesQueue` can have fewer than `k` results when the global update happens, but that makes sense. A couple of things: 1. I brought in your patch (tweaked just a little bit) into this PR. 2. Seems like a test would be useful to cover the bug you exposed. I'll try to add something here to cover that soon. 3. Could you share any details on how you're running luceneutil? I don't really have experience benchmarking in the KNN space (trying to "learn to fish" here). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
