benwtrent commented on PR #13463:
URL: https://github.com/apache/lucene/pull/13463#issuecomment-2155488471
@gsmiller I think your patch has a bug. I tried running with Lucene util to
benchmark this to see if there is any perf change and got an exception. I am
verifying my settings, but wanted to warn you sooner rather than later.
```
Exception in thread "main" java.lang.IllegalStateException: The heap is empty
at org.apache.lucene.util.hnsw.FloatHeap.poll(FloatHeap.java:82)
at
org.apache.lucene.search.knn.MultiLeafKnnCollector.collect(MultiLeafKnnCollector.java:112)
at
org.apache.lucene.util.hnsw.OrdinalTranslatedKnnCollector.collect(OrdinalTranslatedKnnCollector.java:64)
at
org.apache.lucene.util.hnsw.HnswGraphSearcher.searchLevel(HnswGraphSearcher.java:242)
at
org.apache.lucene.util.hnsw.HnswGraphSearcher.search(HnswGraphSearcher.java:105)
at
org.apache.lucene.util.hnsw.HnswGraphSearcher.search(HnswGraphSearcher.java:70)
at
org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsReader.search(Lucene99HnswVectorsReader.java:263)
at
org.apache.lucene.codecs.perfield.PerFieldKnnVectorsFormat$FieldsReader.search(PerFieldKnnVectorsFormat.java:275)
at
org.apache.lucene.index.CodecReader.searchNearestVectors(CodecReader.java:262)
at
org.apache.lucene.search.KnnFloatVectorQuery.approximateSearch(KnnFloatVectorQuery.java:95)
at
org.apache.lucene.search.AbstractKnnVectorQuery.getLeafResults(AbstractKnnVectorQuery.java:127)
at
org.apache.lucene.search.AbstractKnnVectorQuery.searchLeaf(AbstractKnnVectorQuery.java:109)
at
org.apache.lucene.search.AbstractKnnVectorQuery.lambda$rewrite$0(AbstractKnnVectorQuery.java:92)
at
org.apache.lucene.search.TaskExecutor$TaskGroup.lambda$createTask$0(TaskExecutor.java:117)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at
org.apache.lucene.search.TaskExecutor$TaskGroup.invokeAll(TaskExecutor.java:152)
at org.apache.lucene.search.TaskExecutor.invokeAll(TaskExecutor.java:76)
at
org.apache.lucene.search.AbstractKnnVectorQuery.rewrite(AbstractKnnVectorQuery.java:94)
at
org.apache.lucene.search.KnnFloatVectorQuery.rewrite(KnnFloatVectorQuery.java:45)
at
org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:741)
at
org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:752)
at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:634)
at
org.apache.lucene.search.IndexSearcher.searchAfter(IndexSearcher.java:483)
at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:506)
at knn.KnnGraphTester.doKnnVectorQuery(Unknown Source)
at knn.KnnGraphTester.testSearch(Unknown Source)
at knn.KnnGraphTester.run(Unknown Source)
at knn.KnnGraphTester.runWithCleanUp(Unknown Source)
at knn.KnnGraphTester.main(Unknown Source)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
