mikemccand commented on code in PR #13395:
URL: https://github.com/apache/lucene/pull/13395#discussion_r1610019010


##########
lucene/core/src/java/org/apache/lucene/search/Scorer.java:
##########
@@ -98,4 +100,14 @@ public int advanceShallow(int target) throws IOException {
    * {@link #advanceShallow(int) shallow-advanced} to included and {@code 
upTo} included.
    */
   public abstract float getMaxScore(int upTo) throws IOException;
+
+  /** Set whether we can match all docs in this scored segment. */
+  public void setMatchAll(boolean isMatchAll) {

Review Comment:
   Hmm adding this API to such a widely used class (`Scorer`) makes me nervous 
-- it means consumers of `Scorer` can suddenly `setMatchAll` without being true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to