ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1608169944
########## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentFlatVectorsScorer.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.internal.vectorization; + +import java.io.IOException; +import org.apache.lucene.codecs.hnsw.DefaultFlatVectorScorer; +import org.apache.lucene.codecs.hnsw.FlatVectorsScorer; +import org.apache.lucene.index.VectorSimilarityFunction; +import org.apache.lucene.util.hnsw.RandomAccessVectorValues; +import org.apache.lucene.util.hnsw.RandomVectorScorer; +import org.apache.lucene.util.hnsw.RandomVectorScorerSupplier; + +public class MemorySegmentFlatVectorsScorer implements FlatVectorsScorer { + + public static final MemorySegmentFlatVectorsScorer INSTANCE = + new MemorySegmentFlatVectorsScorer(DefaultFlatVectorScorer.INSTANCE); + + private final FlatVectorsScorer delegate; + + public MemorySegmentFlatVectorsScorer(FlatVectorsScorer delegate) { + this.delegate = delegate; + } + + @Override + public RandomVectorScorerSupplier getRandomVectorScorerSupplier( + VectorSimilarityFunction similarityType, RandomAccessVectorValues vectorValues) + throws IOException { + // currently only supports binary vectors + if (vectorValues instanceof RandomAccessVectorValues.Bytes && vectorValues.getSlice() != null) { + var scorer = + Lucene99MemorySegmentByteVectorScorerSupplier.create( Review Comment: I gave this the `Lucene99` prefix in the name, as requested by Ben - which is reasonable - , when I removed a TODO comment about supporting potential trailing per-vector metadata, e.g. the SQ offset or whatever. We could reconsider that later, if we need to evolve this format, in which case it would then not be Lucene99 specific. It would be "calculate the byte offset of vector `n`, by `n * (dims + m)`, where `m` is the byte size of the metadata". Alternatively, we could retain the current implementation and, subject to refactoring for reuse, provide an alternative, which would be then be used in the updated KnnVectorsFormats. Well, switch the public accessors to return the new default, and provide an old format accessor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
