jpountz commented on code in PR #13330:
URL: https://github.com/apache/lucene/pull/13330#discussion_r1587950557
##########
lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/VariableGapTermsIndexReader.java:
##########
@@ -168,22 +165,6 @@ public FieldIndexEnum getFieldEnum(FieldInfo fieldInfo) {
@Override
public void close() throws IOException {}
- @Override
- public long ramBytesUsed() {
- long sizeInBytes = 0;
- for (FST<Long> entry : fields.values()) {
Review Comment:
These FSTs are on-heap and could get large indeed. I'm removing
`Accountable` here to simplify and because I'd expect very few users if any to
take advantage of it as it's a non-default postings format
(`LuceneVarGapFixedInterval` and `LuceneVarGapDocFreqInterval`) and requires a
lot of casting to get access to the Accountable interface: first casting the
LeafReader into a CodecReader to be able to pull a PostingsReader, then casting
the PostingsReader into an Accountable before PostingsReader no longer
implements Accountable since 9.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
