benwtrent commented on code in PR #13330:
URL: https://github.com/apache/lucene/pull/13330#discussion_r1585037924
##########
lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/VariableGapTermsIndexReader.java:
##########
@@ -168,22 +165,6 @@ public FieldIndexEnum getFieldEnum(FieldInfo fieldInfo) {
@Override
public void close() throws IOException {}
- @Override
- public long ramBytesUsed() {
- long sizeInBytes = 0;
- for (FST<Long> entry : fields.values()) {
Review Comment:
I thought FST's can get pretty large? Or is all the main cost off-heap &
no-one really looks at ram-bytes usage for the TermsIndexReader?
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##########
@@ -121,9 +121,6 @@ void initIndexInput() {
public Stats computeBlockStats() throws IOException {
Stats stats = new Stats(fr.parent.segment, fr.fieldInfo.name);
- if (fr.index != null) {
- stats.indexNumBytes = fr.index.ramBytesUsed();
- }
Review Comment:
This removes all writing to `indexNumBytes`? Do we want to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
