jpountz commented on PR #13222: URL: https://github.com/apache/lucene/pull/13222#issuecomment-2037526473
@uschindler I'm curious what you think of this PR now that `ReadAdvice#RANDOM` is the default. Should we keep calling `state.context.withReadAdvice(ReadAdvice.RANDOM)` to be explicit about the expected access pattern (what the PR is doing now) or should we lean on the default being `ReadAdvice.RANDOM`? In the latter case, we would only need to keep the changes in `Lucene99FlatVectorsWriter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org