jpountz commented on PR #13222: URL: https://github.com/apache/lucene/pull/13222#issuecomment-2022902471
> What do you think? I had similar thoughts is mind, so that sounds good to me. I'm still curious about how to fix the bigger issue wrt reader pooling. Should `getMergeInstance()` open fresh new `IndexInput`s? Or maybe we avoid reusing readers across searching and merging, and we'll open a fresh new reader if we need to merge, even though the same segment may already be open for search? > After merging the file is closed and deleted later. Then the pages get freed automatically, so I don't understand the whole issue that Mike has seen. This only happens after the whole merge is finished. So if you're merging a 5GB segment, and it takes time, it's still a fair amount of page cache that merges are taking from searches. If pages could be more aggressively reclaimed while the merge is running, this could help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
