tteofili commented on code in PR #13225: URL: https://github.com/apache/lucene/pull/13225#discussion_r1541314263
########## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ########## @@ -949,4 +951,58 @@ public int hashCode() { return 31 * classHash() + docs.hashCode(); } } + + public void testSameFieldDifferentFormats() throws IOException { Review Comment: thanks @mayya-sharipova. I do see the point. Another option might be to extend `LuceneTestCase` to have some `#randomVectorFormat` method which gives random `KnnVectorFormats` to be used in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org