mayya-sharipova commented on code in PR #13225:
URL: https://github.com/apache/lucene/pull/13225#discussion_r1541305072


##########
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##########
@@ -949,4 +951,58 @@ public int hashCode() {
       return 31 * classHash() + docs.hashCode();
     }
   }
+
+  public void testSameFieldDifferentFormats() throws IOException {

Review Comment:
   +1 on the test itself. I wonder if a better place for it would be in a 
different test file (e.g. `TestLucene99HnswVectorsFormat`). I like how 
`BaseKnnVectorQueryTestCase` is not dependant on the format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to