benwtrent commented on PR #13224: URL: https://github.com/apache/lucene/pull/13224#issuecomment-2022932116
I agree with @jpountz 's concern here. But I think the `zero` checks can be done as things are read in and we can return the static object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org