benwtrent commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1540991260
##########
lucene/core/src/java/org/apache/lucene/util/packed/DirectMonotonicReader.java:
##########
@@ -39,6 +39,9 @@ public final class DirectMonotonicReader extends LongValues
implements Accountab
* from disk.
*/
public static class Meta implements Accountable {
+
+ private static final Meta SINGLE_ZERO_BLOCK = new Meta(1L, 16);
Review Comment:
My concern is that nothing is preventing other things in this package from
mutating the internal arrays (they are package private, not actually private).
Can we make them all members of the Meta class private and final?
From what I can tell, they are only ever used in the `DirectMonotonicReader`
and indeed only mutated once during construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
