kaivalnp commented on code in PR #13202:
URL: https://github.com/apache/lucene/pull/13202#discussion_r1540166440
##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenFloatKnnVectorQuery.java:
##########
@@ -100,8 +102,15 @@ protected TopDocs exactSearch(LeafReaderContext context,
DocIdSetIterator accept
fi.getVectorSimilarityFunction());
final int queueSize = Math.min(k, Math.toIntExact(acceptIterator.cost()));
HitQueue queue = new HitQueue(queueSize, true);
+ TotalHits.Relation relation = TotalHits.Relation.EQUAL_TO;
ScoreDoc topDoc = queue.top();
while (vectorScorer.nextParent() != DocIdSetIterator.NO_MORE_DOCS) {
+ // Mark results as partial if timeout is met
+ if (queryTimeout != null && queryTimeout.shouldExit()) {
+ relation = TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO;
+ break;
+ }
Review Comment:
Also wanted some opinions here: we're checking the timeout in exact search
of `DiversifyingChildren[Byte|Float]KnnVectorQuery` once per-parent (as opposed
to once per document elsewhere)
Should we update this to once per-child as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
