kaivalnp commented on code in PR #13202:
URL: https://github.com/apache/lucene/pull/13202#discussion_r1540162745
##########
lucene/core/src/test/org/apache/lucene/search/TestKnnByteVectorQuery.java:
##########
@@ -102,14 +103,34 @@ public void testVectorEncodingMismatch() throws
IOException {
}
}
+ public void testTimeout() throws IOException {
Review Comment:
Makes sense!
There was a consideration here that the number of levels in the HNSW graph
should be == 1, because if the timeout is hit while finding the best entry
point for the last level, we haven't collected any results yet. I think this
should be fine as we're only indexing 3 vectors, and running these tests for a
few thousand times did not give an error. Added a note about this as well
Also fixed [another
place](https://github.com/apache/lucene/blob/1f909baca5496d5ea7d06d6e83f3b0c54756d8e2/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java#L253-L256)
where the timeout needs to be checked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
