mikemccand commented on code in PR #13206:
URL: https://github.com/apache/lucene/pull/13206#discussion_r1539246356
##########
lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java:
##########
@@ -73,6 +73,7 @@ public class NRTCachingDirectory extends FilterDirectory
implements Accountable
new SingleInstanceLockFactory(),
ByteBuffersDataOutput::new,
(fileName, content) -> {
+ if (!isCachedFile(fileName)) return null;
Review Comment:
In addition to the small style comments up above, could you also please add
a comment explaining that this check is defensive/paranoia to handle deleting a
file that is still open for writing, which Lucene should never do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
