mikemccand commented on code in PR #13206:
URL: https://github.com/apache/lucene/pull/13206#discussion_r1539244396
##########
lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java:
##########
@@ -118,7 +119,9 @@ public synchronized void deleteFile(String name) throws
IOException {
System.out.println("nrtdir.deleteFile name=" + name);
}
if (cacheDirectory.fileExists(name)) {
+ long size = cacheDirectory.fileLength(name);
cacheDirectory.deleteFile(name);
+ cacheSize.addAndGet(-size);
Review Comment:
Could we hold onto the returned (get'd) value and assert that it never drops
below zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
