rmuir commented on code in PR #13209:
URL: https://github.com/apache/lucene/pull/13209#discussion_r1537576805
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/snowball/SnowballPorterFilterFactory.java:
##########
@@ -59,7 +59,13 @@ public class SnowballPorterFilterFactory extends
TokenFilterFactory implements R
/** Creates a new SnowballPorterFilterFactory */
public SnowballPorterFilterFactory(Map<String, String> args) {
super(args);
- language = get(args, "language", "English");
+ String lang = get(args, "language", "English");
+ // it was called "German2" for eons, but snowball folded it into "German"
and deleted "German2"
Review Comment:
The filter has two constructors:
```
/** takes explicit instance: we can't provide back compat/user help here
unless we generate subclass or something messy */
SnowballFilter(TokenStream, SnowballStemmer)
/** takes string: here we map German2 to German */
SnowBallFilter(TokenStream, String)
```
The factory does reflection itself and uses the first ctor. So it needs the
mapping too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
