uschindler commented on code in PR #13209:
URL: https://github.com/apache/lucene/pull/13209#discussion_r1537494919
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/snowball/SnowballFilter.java:
##########
@@ -70,6 +70,11 @@ public SnowballFilter(TokenStream input, SnowballStemmer
stemmer) {
public SnowballFilter(TokenStream in, String name) {
super(in);
Objects.requireNonNull(name, "name");
+ // it was called "German2" for eons, but snowball folded it into "German"
and deleted "German2"
+ // for now, don't annoy our users...
+ if (name.equals("German2")) {
Review Comment:
It's ok to delegate German2 to German.
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/snowball/SnowballPorterFilterFactory.java:
##########
@@ -59,7 +59,13 @@ public class SnowballPorterFilterFactory extends
TokenFilterFactory implements R
/** Creates a new SnowballPorterFilterFactory */
public SnowballPorterFilterFactory(Map<String, String> args) {
super(args);
- language = get(args, "language", "English");
+ String lang = get(args, "language", "English");
+ // it was called "German2" for eons, but snowball folded it into "German"
and deleted "German2"
Review Comment:
This code is not required as the filter itself renames, but looks still fine
to change early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
