jpountz commented on code in PR #13190:
URL: https://github.com/apache/lucene/pull/13190#discussion_r1533418454
##########
lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java:
##########
@@ -445,8 +456,15 @@ private static String rateToString(double mbPerSec) {
}
@Override
- public void close() {
- sync();
+ public void close() throws IOException {
+ super.close();
Review Comment:
nit: should we try to close as cleanly as possible in the event of an
exception, e.g. doing something like below
```java
IOUtils.close(
this::sync,
super::close,
intraMergeExecutor == null ? null : intraMergeExecutor::shutdown);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
