zhaih commented on code in PR #13124:
URL: https://github.com/apache/lucene/pull/13124#discussion_r1525307991
##########
lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java:
##########
@@ -902,12 +932,52 @@ private static String getSegmentName(MergePolicy.OneMerge
merge) {
}
static {
- TestSecrets.setConcurrentMergeSchedulerAccess(
- new ConcurrentMergeSchedulerAccess() {
- @Override
- public void setSuppressExceptions(ConcurrentMergeScheduler cms) {
- cms.setSuppressExceptions();
- }
- });
+
TestSecrets.setConcurrentMergeSchedulerAccess(ConcurrentMergeScheduler::setSuppressExceptions);
+ }
+
+ private class CachedExecutor implements Executor {
Review Comment:
Can we have some simple javadoc explaining what this executor is doing? E.g.
will use a spare thread if it is within configured max thread and will run
directly on caller thread if we have no extra thread available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
