uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961117087
Basically, to make the whole script better maintainable: - remove the hardcoded Java 17, Java 11 variable names. - have a central setting with the "baseline" java version. - When running the code it would just check that JAVA_HOME is exactly the baseline version and all other additionally added JVM versions should - Finally, the gradle tasks should not be executed with a changes JAVA_HOME. Instead the RUNTIME_JAVA_HOME env var should be poulated and Gradle be running with the base version. This removes the problem of not being able to execute Gradle with Java 22 - Special case: Everything executed using without Gradle (like the Lucene Demo) should of course be executed the JAVA_HOME env var, so they are directly executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
