uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947486317
> That's great! If we extract the JDK version number as well, maybe we can commit this. Extracting the JDK version number is already implemented, because there's a check for Java 11 and Java 17 already. > @uschindler - would you want the parameter for a specific JDK version removed on both `main` and `branch_9x` i.e. remove `--test-java19` from `main` and remove `--test-java17` from `branch_9x`? I would remove all of them. Only the base version should be checked (so in 9.x base version must be 11). The other versions passed as cmd line parameter should maybe just checked to be >= base version. If you want backwards compatibility, you can keep the old cmd line parameters and just add the arguments from the specific parameters to the list of alternative versions. But as this is a developer tools only, I don't think we need any backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
