believezzd commented on PR #174: URL: https://github.com/apache/lucene/pull/174#issuecomment-1959010131
@jpountz ## Description * There are two place code that i can't understand in this commit, could you please give me help. ## First one * To ZstdStoredFieldsFormat#ZstdDecompressor.decompress(124) * why it has to skip blocks. As I know, in the compress, the compressed sub_block appends to output one by one. it it just decompress from offset to offset+length. Just As DeflateDecompressor.decompress ## Second one * To ZstdStoredFieldsFormat#ZstdDecompressor.decompress(145) * why it reset bytes.offset and bytes.length to other value in the end. As I can see, in the end, bytes.offset should be zero and bytes.length should be originalLength. Same as DeflateDecompressor.decompress in the end. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
