benwtrent commented on PR #13124: URL: https://github.com/apache/lucene/pull/13124#issuecomment-1957696114
> it would be nice to fully encapsulate the merging concurrency there instead of having two sources of merging concurrency that are not aware of one another. To take advantage of the executor, etc. it needs to be accessible from the scheduler. So, we would have to update the `MergeScheduler` to have some methods to return the executor for us to use and pass to `MergeState` (which is only created via the `SegmentMerger` object). This means that the scheduler for individual merges and the parallelism available to those individual merges are independent. I don't know how they would ever be "aware" of one another. > I'm also keen on keeping the codec API as simple as possible and adding the executor as a member of the MergeState rather than a new parameter of all codec write APIs. I updated the PR to do just this. Its a much cleaner API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
