easyice opened a new pull request, #13089: URL: https://github.com/apache/lucene/pull/13089
Some years ago, there was a patch for `TestDocumentsWriterDeleteQueue.testUpdateDeleteSlices` see https://issues.apache.org/jira/browse/LUCENE-4066, At the time, `DocumentsWriterDeleteQueue#numGlobalTermDeletes` returns the number without deduplication deleted terms,so the expeced value is `j + 1`, After https://github.com/apache/lucene/pull/12586 , it will return unique value(with deduplication). In this PR, we use `uniqueValues.size` as expected value. I read the code related to this change, it seems related to test code only, no other issues. cc @gf2121 ``` ./gradlew :lucene:core:test --tests "org.apache.lucene.index.TestDocumentsWriterDeleteQueue.testUpdateDeleteSlices" -Ptests.heapsize=32g -Ptests.jvms=6 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1" -Ptests.seed=60A190443031BE92 -Ptests.nightly=true -Ptests.gui=false -Ptests.file.encoding=ISO-8859-1 -Ptests.vectorsize=256 -Dtests.multiplier=3 ``` ``` > java.lang.AssertionError: expected:<403> but was:<402> > at __randomizedtesting.SeedInfo.seed([60A190443031BE92:77AEF54BB4FE82A7]:0) > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:633) > at org.apache.lucene.index.TestDocumentsWriterDeleteQueue.testUpdateDeleteSlices(TestDocumentsWriterDeleteQueue.java:70) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
