rmuir commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-1930648432
which of the current functions really need to be in core? I guess the problem I see is that there are 6 functions today, 3 float, 3 byte. The byte functions don't perform well and never will. They require 32 bits to return `int` result so they aren't any faster than 32-bit `float`, just more overhead. Sure, if you have 10M vectors maybe you save a few megabytes, but if you have 10M vectors, that is such a drop in the bucket compared to the rest of your hardware, that it would be better to just have used faster floating-point vectors. So my question: which of all these 6 functions really needs to be supported in core? I don't think its needed to have a byte variant for every float function either (this PR shows that). So we shouldn't add functions "just because", but consider the cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
