uschindler commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-1930363479
In general, I'd like to rethink the plugabble VectorSimilarities (per field). IMHO, the VectorSimilarity class should NOT be an ENUM and instead be an SPI with a symbolic name (using `NamedSPILoader` for the lookup) and the name should be stored in `FieldInfo`. I don't know how the current serialization to fieldinfos is done, but if it just stores the ENUM ordinal number we have a problem anyways (we can't remove constants then). If this is the case it would be top priority to change from ordinals to SPI names, because we can't remove enum constants if only the ordinal is used. For backwards compatibility we should have a hardcoded mapping of the old lookup keys in the older fieldinfos format. I'd like to open a new issue about this. @rmuir and I were a bit shocked about the increase of similarity functions in the last year. This vector similarity discussed here should then first go into the sandbox module, so we do not need to keep backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
