jpountz commented on PR #13027:
URL: https://github.com/apache/lucene/pull/13027#issuecomment-1904218681
   OK, taking an int in that method sounds fine to me. Can we still preserve 
the signature of `mergeOneField` to return `void` and re-compute the doc count 
before passing the doc count to `ScalarQuantizer#fromVectors`? Returning the 
doc count feels a bit arbitrary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to