msfroh commented on code in PR #12995:
URL: https://github.com/apache/lucene/pull/12995#discussion_r1454250264
##########
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java:
##########
@@ -669,20 +668,26 @@ public void testChildrenArraysInvariants() throws
Exception {
// Find the youngest older sibling:
int j;
for (j = i - 1; j >= 0; j--) {
- if (parents[j] == parents[i]) {
+ if (parents.get(j) == parents.get(i)) {
break; // found youngest older sibling
}
}
if (j < 0) { // no sibling found
j = TaxonomyReader.INVALID_ORDINAL;
}
- assertEquals(j, olderSiblingArray[i]);
+ assertEquals(j, olderSiblingArray.get(i));
}
tr.close();
indexDir.close();
}
+ private static void assertArrayEquals(int[] expected,
ParallelTaxonomyArrays.IntArray actual) {
Review Comment:
This was the only place where we assert anything about the full contents of
the `ChunkedArray`. I would lean toward not adding `equals` to `ChunkedArray`,
since it's not something we would normally want to call, IMO. (In general, it's
going to be pretty expensive.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
