stefanvodita commented on code in PR #12995:
URL: https://github.com/apache/lucene/pull/12995#discussion_r1444224140
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java:
##########
@@ -68,25 +90,49 @@ public TaxonomyIndexArrays(IndexReader reader,
TaxonomyIndexArrays copyFrom) thr
// it may be caused if e.g. the taxonomy segments were merged, and so an
updated
// NRT reader was obtained, even though nothing was changed. this is not
very likely
// to happen.
- int[] copyParents = copyFrom.parents();
- this.parents = new int[reader.maxDoc()];
- System.arraycopy(copyParents, 0, parents, 0, copyParents.length);
- initParents(reader, copyParents.length);
-
+ int[][] parentArray = allocateChunkedArray(reader.maxDoc());
+ copyChunkedArray(copyFrom.parents.values, parentArray);
+ initParents(parentArray, reader, copyFrom.parents.length());
+ parents = new ChunkedArray(parentArray);
if (copyFrom.initializedChildren) {
initChildrenSiblings(copyFrom);
}
}
+ private static int[][] allocateChunkedArray(int size) {
+ int chunkCount = size / CHUNK_SIZE + 1;
+ int lastChunkSize = size % CHUNK_SIZE;
+ int[][] array = new int[chunkCount][];
+ if (array.length > 0) {
+ for (int i = 0; i < chunkCount - 1; i++) {
+ array[i] = new int[CHUNK_SIZE];
+ }
+ array[chunkCount - 1] = new int[lastChunkSize];
+ }
+ return array;
+ }
+
+ private static void copyChunkedArray(int[][] oldArray, int[][] newArray) {
+ // Copy all but the last (maybe partial) chunk from the old array
+ if (oldArray.length > 1) {
+ System.arraycopy(oldArray, 0, newArray, 0, oldArray.length - 1);
+ }
+ int[] lastCopyChunk = oldArray[oldArray.length - 1];
+ System.arraycopy(lastCopyChunk, 0, newArray[oldArray.length - 1], 0,
lastCopyChunk.length);
Review Comment:
Actually, I guess the real concern here is that the last array is not
properly sized, so always deep-copying it makes sense, since it's capacity
requirements will have always changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
