uschindler commented on code in PR #13001: URL: https://github.com/apache/lucene/pull/13001#discussion_r1446133887
########## gradle/validation/forbidden-apis/defaults.all.txt: ########## @@ -74,3 +74,8 @@ javax.sql.rowset.spi.SyncFactory @defaultMessage Math.fma is insanely slow (2500x) in many environments (e.g. VMs). Use multiply/add and suffer the extra rounding java.lang.Math#fma(float,float,float) java.lang.Math#fma(double,double,double) + +@defaultMessage We should not use Thread.sleep in lucene code +java.lang.Thread#sleep(long) Review Comment: I'd use `java.lang.Thread#sleep(**)`. This prevents any sleep variant coming soon. E.g., the Duration one not yet available in JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
