dweiss commented on code in PR #12979:
URL: https://github.com/apache/lucene/pull/12979#discussion_r1437827341
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -409,8 +408,8 @@ public static final class IndexSortStatus {
}
/** Status from testing soft deletes */
- public static final class SoftDeletsStatus {
- SoftDeletsStatus() {}
+ public static final class SoftDeletesStatus {
Review Comment:
Just FYI - I know it's tempting to do such cleanups as you browse the files
for other things but it makes reviewing more complex. It'd be nice if the
patches were focused on one thing - if it says replace "utf-8" constant with
StandardCharsets.UTF-8, it'd be easier to review and apply if the patch didn't
do other things, like renaming public classes, removing final, or access scope
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
