uschindler commented on issue #12916: URL: https://github.com/apache/lucene/issues/12916#issuecomment-1861877749
Hi, The proposed fix is looking fine to me. Please note that all other accessible methods in that class are synchronized (or private ones implicitly synchronized as only called from synchronized ones). Just this one isn't and this causes trouble. I think the fix mentioned here is fine and fixes a real bug which may also happen on Hotspot on some other hardware platform. It does not fail on x86 with hotspot. ARM could fail due to other memory behaviour and order. I will provide a PR to add synchronized tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
