uschindler commented on PR #12933: URL: https://github.com/apache/lucene/pull/12933#issuecomment-1855691742
> > The test is not the nicest looking thing, but I accept it, because it doesn't break classloading of resources. 👍 > > Ha! I take this a strong positive feedback @uschindler ;) hehe, I was initially thinking about some method in the FST class like `isFSTLatestVersion(InputStream in)`, but I think this is too much abstraction. I was just worried about the code duplication. If we get more Jarred FSTs anywhere else, we can rethink this and move that to LuceneTestCase class. So all is fine, lets merge this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
