mikemccand opened a new pull request, #12933: URL: https://github.com/apache/lucene/pull/12933
Closes #12911 This just adds specific unit tests for the binary FST for Nori's and Kuromoji's `TokenInfoDictionary`. I had to promote some APIs from private -> package private for test visibility. I backed out this AM's FST upgrade confirmed the tests fail, with something like this: ``` java.lang.AssertionError: TokenInfoDictionary's FST is not the latest version: expected 9 but got: 8; run "./gradlew regenerate" to regenerate this FST and all other resources expected:<9> but was:<8> at __randomizedtesting.SeedInfo.seed([32EBD74005BEF4E1:C57DC409B3CCC027]:0) at junit@4.13.1/org.junit.Assert.fail(Assert.java:89) at junit@4.13.1/org.junit.Assert.failNotEquals(Assert.java:835) at junit@4.13.1/org.junit.Assert.assertEquals(Assert.java:647) at org.apache.lucene.analysis.ja.dict.TestTokenInfoDictionary.testBinaryFSTIsLatestFormat(TestTokenInfoDictionary.java:192) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org