gsmiller commented on PR #12890: URL: https://github.com/apache/lucene/pull/12890#issuecomment-1847461557
IMO we should deprecate these without replacement. I agree that users should be able to implement this logic pretty easily in their application layer, and would probably be better suited to do so. For example, if a user doesn't want to collect actual hits and just do faceting, these methods are a little trappy since they internally decide to also do a full (accurate) count of hits. They're baking in some assumptions like this that users may not expect. Just my opinion of course. I don't feel all that strongly about it, and if we want some convenience functionality somewhere for this, that's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
