zacharymorn opened a new pull request, #12890: URL: https://github.com/apache/lucene/pull/12890
This is a WIP / discussion only PR. As the next step for https://github.com/apache/lucene/issues/11041, I'm thinking to deprecate FacetsCollector#search methods as they internally use IndexSearcher#search(Query, Collector) API. However, I'm a bit torn on whether we should create new replacement methods for them, or could just deprecate them without replacement, since the logic looks like something application developers could naturally come up with as well (and I don't like creating an extra `Pair` class just for returning multiple values for these helper methods)? Please let me know if you have any suggestion on this @mikemccand @jpountz @javanna @gsmiller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
