uschindler commented on PR #12873: URL: https://github.com/apache/lucene/pull/12873#issuecomment-1839826543
> I like the change! > > Can be a followup ticket, but i think we should remove `ClassLoader` usage from `TestCustomFunctions.java`. It doesn't need to use classloader to test anymore, since it can just pass a MethodHandle: so maybe the test is easy to fix. With that test fixed, `createClassLoader` permission can be removed from tests, lucene code really shouldn't be messing with classloaders if we have a more optimal way? I cleaned up the policy files, but the `createClassLoader` permission is still needed by the the Jacoco agent, which uses no AccessController.... So I can't limit access. But I moved the permission to the Jacoco ones. We may open a bug report for Jacoco to fix this. I was successful with removing `getClassLoader` permission. This one is no longer needed as we are no longer inspecting classloaders of unknown classes. I think this permission can also be removed in 9.x. Finally I removed some permission from replication in main branch caused by servlet API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
