rmuir commented on PR #12873: URL: https://github.com/apache/lucene/pull/12873#issuecomment-1839192204
I like the change! Can be a followup ticket, but i think we should remove `ClassLoader` usage from `TestCustomFunctions.java`. It doesn't need to use classloader to test anymore, since it can just pass a MethodHandle: so maybe the test is easy to fix. With that test fixed, `createClassLoader` permission can be removed from tests, lucene code really shouldn't be messing with classloaders if we have a more optimal way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
