mikemccand commented on PR #12850: URL: https://github.com/apache/lucene/pull/12850#issuecomment-1831732238
> The test assertions depend on doc order which may be affected by merging. Hmm, I don't fully understand the test, but did the sort order truly rely on `docid` tie-breaking? If so then this is the right fix. I just want to make sure we are not hiding a bug that e.g. causes this sorter to incorrectly sort / compare documents across segments that were not in fact ties by the sort criteria. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
