Re: [I] Move group-varint encoding/decoding logic to DataOutput/DataInput? [lucene]

[via GitHub]

easyice commented on issue #12826:
URL: https://github.com/apache/lucene/issues/12826#issuecomment-1824101886

   Thanks for explaining! you are right, if we call `DataInput.readVIntGroup`, 
the  function  `DataInput.readVIntGroupLong`(the same as 
`GroupVIntReader#readLong`) is not inlined, But if we switch to  
`readVIntGroupFully`,  the `DataInput.readVIntGroupLong` can be inlined.
   
   **baseline**, use `GroupVIntReader#readValues` , the 
`GroupVIntReader#readLong` is inlined:
   
![image](https://github.com/apache/lucene/assets/23521001/66706628-c3cf-43a4-81b5-4ce7433e045b)
   
   
   **approach_1**, switch to `DataInput.readVIntGroup`, the  
`DataInput.readVIntGroupLong` is NOT inlined:
   
![image](https://github.com/apache/lucene/assets/23521001/0a37c894-0de0-4b33-b0c5-864f73e8cf9a)
   
   
   **approach_2**, switch to `DataInput.readVIntGroupFully`, the  
`DataInput.readVIntGroupLong` is inlined:
   
![image](https://github.com/apache/lucene/assets/23521001/f1ab8850-decf-42e3-8bdd-ea0bee0270c5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org