javanna commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1399656766
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -489,8 +490,9 @@ private void writeMeta(
private HnswGraphMerger createGraphMerger(
FieldInfo fieldInfo, RandomVectorScorerSupplier scorerSupplier) {
if (mergeExec != null) {
+ TaskExecutor taskExecutor = new TaskExecutor(mergeExec);
Review Comment:
Can't this class hold directly a TaskExecutor instead of an ExecutorService?
The null check can be made against the task executor too? That way we would
create a single task executor instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
