mikemccand opened a new pull request, #12805:
URL: https://github.com/apache/lucene/pull/12805

   I noticed yet another errant `;` and then grep'd and found tons of them and 
removed them.
   
   Note that it was a bit tricky because some lines that have only whitespace 
and a semicolon are actually meaningful, e.g.:
   
   ```
     while(something)
         ;
   ```
   
   I translated those cases to:
   
   ```
     while(something) {
     }
   ```
   
   instead.
   
   If a `for` loop definition spans multiple lines, it can have a meaningful 
semicolon-only line -- there was at least one case of this.
   
   I tried not to touch any auto-gen'd code, which seem to contain many errant 
semicolons, unfortunately.
   
   I wonder if there is a "useless semicolon" static checker?  Now that I see 
these things I cannot unsee them!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to