mikemccand commented on code in PR #12715: URL: https://github.com/apache/lucene/pull/12715#discussion_r1392585037
########## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ########## @@ -125,8 +125,11 @@ public class FSTCompiler<T> { /** * Instantiates an FST/FSA builder with default settings and pruning options turned off. For more * tuning and tweaking, see {@link Builder}. + * + * @deprecated Use FSTCompiler.Builder instead. This method will be removed in an upcoming major + * release. */ - // TODO: remove this? Builder API should be the only entry point? + @Deprecated public FSTCompiler(FST.INPUT_TYPE inputType, Outputs<T> outputs) { Review Comment: I'll merge this now, and we can separately fold this feedback. It's holding up some changes on #12624. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org