mikemccand commented on code in PR #12715:
URL: https://github.com/apache/lucene/pull/12715#discussion_r1391162919
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -125,8 +125,11 @@ public class FSTCompiler<T> {
/**
* Instantiates an FST/FSA builder with default settings and pruning options
turned off. For more
* tuning and tweaking, see {@link Builder}.
+ *
+ * @deprecated Use FSTCompiler.Builder instead. This method will be removed
in an upcoming major
+ * release.
*/
- // TODO: remove this? Builder API should be the only entry point?
+ @Deprecated
public FSTCompiler(FST.INPUT_TYPE inputType, Outputs<T> outputs) {
Review Comment:
Let's remove instead?
##########
lucene/CHANGES.txt:
##########
@@ -7,6 +7,8 @@ http://s.apache.org/luceneversions
API Changes
---------------------
+* GITHUB-12695: Deprecated public constructor of FSTCompiler. Please use
FSTCompiler.Builder
Review Comment:
Note that the FST API is `@lucene.internal` so we are free to 1) skip
deprecation -- just remove the old API, and 2) backport to 9.9.
We are delaying backporting all these recent FST changes for now (letting
things bake in trunk) so we would first commit this to `main` and later
backport with the full patch. So for now, let's leave this `CHANGES` entry in
10.0.0 section, but let's remove the deprecated APIs entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
