martijnvg commented on PR #12711: URL: https://github.com/apache/lucene/pull/12711#issuecomment-1805422002
> We could get away with not having the check at all and make blocks a first class citizen by recording the parent document in a docvalues field. Really, if we'd be implementing the feature today would we use a bitset or maybe a sparse DV field recording the number of children for each block in the index? I think adding parent doc values field to the IWC would make block indexing more robust than is today. Other tools would then also know that a Lucene index contains blocks. > You'd still have the power to do what you do today but we can fix documentation that your blocks might be messed up unless you set a field on IWC. Full BWC and less trouble for the users? +1 to keep full bwc. Although I think if this feature were to be build today, then I think failing (incase no parent field is configured) would be the best option here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
