msokolov commented on PR #12711: URL: https://github.com/apache/lucene/pull/12711#issuecomment-1775052675
This is what we do today: we're careful to add blocks of docs that sort together. What is the alternative going to be? Instead one should sequentially call addDocument()? I have a question about this; is indexing sorting stable? If I add multiple docs in a block that share the same sort key, will their order be preserved? I believe this is the case in our current index - so we need the guarantee, and the sorting. If that still works with sequential calls to addDocument, I guess that we can shift to doing that, but in that case I don't understand how preventing the use of this API will be helpful. It seems as if this is sort of an "advice to users" change that really doesn't alter anything substantive? Could we address it with documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
